Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set a default mediaConfiguration to avoid addon crash #1133

Merged
merged 1 commit into from
Jan 24, 2018
Merged

set a default mediaConfiguration to avoid addon crash #1133

merged 1 commit into from
Jan 24, 2018

Conversation

kekkokk
Copy link
Contributor

@kekkokk kekkokk commented Jan 23, 2018

I think we need to set a default mediaConfiguration in case is not passed when creating token

[] It needs and includes Unit Tests
[] It includes documentation for these changes in /doc.

@kekkokk kekkokk mentioned this pull request Jan 23, 2018
Closed
jcague
jcague approved these changes Jan 24, 2018
View reviewed changes
Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@jcague jcague merged commit 77bcd68 into lynckia:master Jan 24, 2018
@kekkokk kekkokk deleted the fix/mediaConfiguration branch June 4, 2018 10:56
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
@kekkokk @jcague
set a default mediaConfiguration to avoid addon crash (lynckia#1133)
31248c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcague jcague jcague approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kekkokk @jcague