Add full simulcast support to recordings #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodoyun
approved these changes
Jan 22, 2018
| @@ -22,6 +23,9 @@ class AsyncCloser : public Nan::AsyncWorker { | |||
| ~AsyncCloser() {} | |||
| void Execute() { | |||
| external_output_->close(); | |||
| while (external_output_->isRecording()) { | |||
There was a problem hiding this comment.
isRecording being false does not imply the ExternalOutput has finished closing. Consider moving the switch of recording_ to false at the end of syncClose
| @@ -0,0 +1,39 @@ | |||
| /* | |||
| * Copyright (c) 2016, Facebook, Inc. | |||
There was a problem hiding this comment.
Correct me if I'm wrong, but didn't you come up with this class? We don't need to put the license here in that case
| @@ -93,7 +109,7 @@ class ExternalOutput : public MediaSink, public RawDataReceiver, public Feedback | |||
| // Note: VP8 purportedly has two packetization schemes; per-frame and per-partition. A frame is | |||
| // composed of one or more partitions. However, we don't seem to be sent anything but partition 0 | |||
| // so the second scheme seems not applicable. Too bad. | |||
| vp8SearchState video_search_state_; | |||
| // vp8SearchState video_search_state_; | |||
There was a problem hiding this comment.
Consider just removing this. It's a leftover from a previous PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It adds a new worker + pipeline to ExternalOutput, so that we can handle simulcast layers and filter them. Now we record the higher available layer, but we might want to create an API in the future to record the lower or any intermediate layers instead.
[] It needs and includes Unit Tests
Changes in Client or Server public APIs
Not needed.
[] It includes documentation for these changes in
/doc.