-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate depacketizer in ExternalOuput adding h264 #1124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@lodoyun This PR allows the creation of recordings using H264 codec? Or the output is still VP8 only? |
@nvazquezg Yes, H.264 recording is supported for H.264 rooms, meaning Licode won't transcode when recording, it will record in the codec that the room is using. |
@lodoyun Understood, thanks. To configure a room as H.264 I've set:
I traced it to here:
Please, tell me if I am doing something wrong or if I need to file an issue. |
@nvazquezg try this
|
@yannistseng that did the trick. Thank you very much! 👍 |
Description
This PR integrates the new
Depacketizer
intoExternalOutput
replacing all the old vp8 depacketizer login. As part of the process of integrating it, this PR updates theDepacketizer
to better suit the rest of Erizo naming conventions and removing thethrow
code.This PR also adds support for H264 in recording new that we have a compatible depacketizer, that required a minor change in
LayerDetectorHandler
to start marking the spatial layer of h264 packets (for now it's always 0).[] It needs and includes Unit Tests
Changes in Client or Server public APIs
[] It includes documentation for these changes in
/doc
.