MediaStreams now use their own worker #1107
Conversation
|
Hello Pedro! |
|
@Trisfald You were right. There was an issue in DtlsTransport that could cause the pipeline to work with outdated packets, that is what was hiding the pipeline order problem. |
| @@ -178,9 +178,7 @@ void DtlsTransport::onIceData(packetPtr packet) { | |||
| } | |||
| return; | |||
| } else if (this->getTransportState() == TRANSPORT_READY) { | |||
| unprotect_packet_->length = len; | |||
There was a problem hiding this comment.
could unprotect_packet_ be local now?
erizo/src/erizo/WebRtcConnection.cpp
Outdated
| @@ -68,6 +68,13 @@ WebRtcConnection::~WebRtcConnection() { | |||
| ELOG_DEBUG("%s message: Destructor ended", toLog()); | |||
| } | |||
|
|
|||
| void WebRtcConnection::close() { | |||
There was a problem hiding this comment.
why do you need to change the location? it might conflict with an ongoing PR ;)
There was a problem hiding this comment.
No particular reason, it liked it better that way. I switched it back.
…o add/MediaStreamWorker
Description
Before this PR MediaStreams shared a worker with the corresponding WebRTCConnection. This PR removes that limitation, instantiating MediaStreams with a different working and properly passing the packet path tasks between the workers.
[] It needs and includes Unit Tests
Changes in Client or Server public APIs
[] It includes documentation for these changes in
/doc.