Fix missing generated nack #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodoyun
reviewed
Dec 19, 2017
| @@ -89,8 +89,7 @@ bool RtcpNackGenerator::addNackPacketToRr(std::shared_ptr<DataPacket> rr_packet) | |||
| base_nack_info.sent_time = now_ms; | |||
| base_nack_info.retransmits++; | |||
| while (index + 1u < nack_info_list_.size()) { | |||
| index++; | |||
| NackInfo& blp_nack_info = nack_info_list_[index]; | |||
| NackInfo& blp_nack_info = nack_info_list_[index + 1]; | |||
| uint16_t distance = blp_nack_info.seq_num - pid -1; | |||
| if (distance <= 15) { | |||
| if (!isTimeToRetransmit(blp_nack_info, now_ms)) { | |||
There was a problem hiding this comment.
We would need another index++ here. Otherwise we'd be stuck testing for the same nack_info until the time is right to send it.
There was a problem hiding this comment.
Didn't see that at all, thanks!
lodoyun
approved these changes
Dec 19, 2017
Arri98
pushed a commit
to Arri98/licode
that referenced
this pull request
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I run into this bug while looking at the nack generator (related to pr #1096 ). Something was off in the sequence of nacks generated and then I found that the first nack of the second blp was always missing.
[X] It needs and includes Unit Tests
The for inside the test case works but maybe the form can be improved
Changes in Client or Server public APIs
[] It includes documentation for these changes in
/doc.