Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add close ErizoController on KeepAlive failure #1067

Merged
merged 3 commits into from
Nov 10, 2017

Conversation

lodoyun
Copy link
Contributor

@lodoyun lodoyun commented Nov 9, 2017

Description
ErizoControllers send keep alive messages to Nuve as a health check. If Nuve receives a message from an unknown (not previously identified) ErizoController, it will answer the keep alive message with whoareyou.

This PR allows to modify the behavior of ErizoController when receiving this message by configuration. If exitOnNuveCheckFail is enabled, ErizoController will automatically exit.

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

[] It includes documentation for these changes in /doc.

@lodoyun lodoyun changed the title Add/close ec on amqp failure Add close ErizoController on KeepAlive failure Nov 9, 2017
Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lodoyun lodoyun merged commit a69ece9 into lynckia:master Nov 10, 2017
@lodoyun lodoyun deleted the add/CloseECOnAMQPFailure branch January 10, 2018 10:18
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants