Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hasAudio and hasVideo to return always a boolean. #1012

Merged
merged 1 commit into from
Aug 21, 2017

Conversation

jcague
Copy link
Contributor

@jcague jcague commented Aug 21, 2017

Description

It fixes hasAudio and hasVideo to return always a boolean in the general case.

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

It just guarantees that hasAudio and hasVideo returns always a boolean.

[] It includes documentation for these changes in /doc.

Copy link
Contributor

@lodoyun lodoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice catch 👍

@jcague jcague merged commit 0cd22e5 into lynckia:master Aug 21, 2017
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants