ui v2: warning invoke onClose before exiting #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you give a bit more detail on the use case here? seems like the data flow for a toast/snackbar should be one way |
|
Currently we maintain a list of global warnings that are shown as toasts on the app. To avoid duplicate toasts being presented at once we ensure that these warnings are unique by only inserting new ones. However, once the toast has cleared from the screen we need a way to signal to the parent that it can send the same warning again. |
danielhochman
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
invoke onClose before the snackbar exits. This allows for the wizard to reset warnings after they have been dismissed.
Testing Performed
manaul