Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui v2: use new alert for note panel and fix layout max width #864

Merged
merged 1 commit into from
Jan 7, 2021
Merged

ui v2: use new alert for note panel and fix layout max width #864

merged 1 commit into from
Jan 7, 2021

Conversation

dschaller
Copy link
Contributor

Description

Update Note and NotePanel to use new alert component. Fix max width of alerts and overflow.

Screen Shot 2021-01-07 at 12 03 35 PM

Testing Performed

manual

@dschaller dschaller requested a review from a team as a code owner January 7, 2021 20:06
danielhochman
danielhochman approved these changes Jan 7, 2021
View reviewed changes
Copy link
Collaborator

@danielhochman danielhochman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the spacing on the second example is pretty rough the icon should probably float in the margin rather than affecting the centering of content

@dschaller
Copy link
Contributor Author

👍 that should be controlled in the content being passed in (in this case it's in a private workflow)

@dschaller dschaller merged commit 6f5ed26 into UIV2 Jan 7, 2021
@dschaller dschaller deleted the notePanelLayout branch January 7, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhochman danielhochman danielhochman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dschaller @danielhochman