ui V2: fix accordion overflow #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhochman
approved these changes
Jan 7, 2021
scarlettperry
commented
Jan 7, 2021
| @@ -17,6 +17,8 @@ const StyledAccordion = styled(MuiAccordion)({ | |||
| boxShadow: "none", | |||
| border: "1px solid transparent", | |||
| boxSizing: "content-box", | |||
| maxWidth: "100%", | |||
| overflowWrap: "anywhere", | |||
There was a problem hiding this comment.
breaks the string at an arbitrary point or where there is a natural break. otherwise, the cells in the row won't share the space evenly in scenario like the one below
|
@danielhochman it's ready for another review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue when accordion overflows its parent container, which happens when there are long strings of text that do not have an acceptable break (ie space, hyphen).
before
now
Testing Performed
Locally and checked stories to make sure it didn't break other functionality/designs