Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui v2: metadata input validation bug #860

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

scarlettperry
Copy link
Contributor

@scarlettperry scarlettperry commented Jan 6, 2021

Description

Address bug bash item:

  • text field validations in the metadata table were not rendering correctly

before
Screen Shot 2021-01-06 at 4 50 34 PM

now
Screen Shot 2021-01-06 at 4 50 34 PM

longer errors
Screen Shot 2021-01-06 at 4 50 43 PM

default
Screen Shot 2021-01-06 at 4 58 26 PM

Testing Performed

Locally

alignSelf: "center",
},
".MuiFormControl-root .MuiFormHelperText-root.Mui-error": {
flex: 1,
Copy link
Contributor Author

@scarlettperry scarlettperry Jan 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to solve for this issue of the input width when there are longer errors
Screen Shot 2021-01-06 at 5 00 55 PM

height: "40px",
width: "100px",
flexDirection: "row",
alignSelf: "center",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so solve for this alignment issue with longer errors

Screen Shot 2021-01-06 at 5 02 15 PM

@scarlettperry scarlettperry marked this pull request as ready for review January 6, 2021 22:02
@scarlettperry scarlettperry requested a review from a team as a code owner January 6, 2021 22:02
@scarlettperry scarlettperry merged commit 3ab9236 into UIV2 Jan 7, 2021
@scarlettperry scarlettperry deleted the sperry-metadata-input-validation branch January 7, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants