ui v2: add end adornment support to text fields #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| InputProps={{ readOnly }} | ||
| InputProps={{ | ||
| readOnly, | ||
| endAdornment: endAdornment && <IconButton type="submit">{endAdornment}</IconButton>, |
There was a problem hiding this comment.
at first glance i wonder if we should take IconButton instead of wrapping it ourselves for further customization, this seems fine though.
There was a problem hiding this comment.
I had that thought too but I can't imagine a situation where we wouldn't want an icon button. Also, the styling applied is overriding some of the icon buttons styles which by default provide a border radius of 50% and have padding
danielhochman
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support to text fields for end adornment
Testing Performed
In dev app and storybook