ui v2: move resolver to accordions #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschaller
reviewed
Dec 11, 2020
| @@ -117,30 +93,27 @@ const Resolver: React.FC<ResolverProps> = ({ type, searchLimit, onResolve, varia | |||
| <Error message={state.schemaFetchError} onRetry={() => loadSchemas(type, dispatch)} /> | |||
| ) : ( | |||
| <Loadable variant="overlay" isLoading={state.resolverLoading}> | |||
| {process.env.REACT_APP_DEBUG_FORMS === "true" && <DevTool control={validation.control} />} | |||
There was a problem hiding this comment.
Should we add back the debug form?
There was a problem hiding this comment.
it doesn't work correctly with multiple validations at once afaict
There was a problem hiding this comment.
ah yeah it would just be the focused one
There was a problem hiding this comment.
i think we no longer know which is focused, which i think we will need to add if we want to do dynamic disable on focus, but complicated enough to defer to another PR. wdyt?
There was a problem hiding this comment.
We can add in a follow up PR
dschaller
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Kept as much existing logic as I could and rewired it for individual forms.
Not worried about styles in this PR, just logic.
Testing Performed
Locally with dev flow.