Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui v2: horizontal rule #723

Merged
merged 4 commits into from
Dec 2, 2020
Merged

ui v2: horizontal rule #723

merged 4 commits into from
Dec 2, 2020

Conversation

danielhochman
Copy link
Collaborator

Description

Adds a horizontal rule that accepts children for display in the middle.

Screenshot from 2020-12-01 11-26-30

Testing Performed

Storybook

@danielhochman danielhochman requested a review from a team as a code owner December 1, 2020 17:27
@danielhochman danielhochman changed the base branch from main to UIV2 December 1, 2020 17:27
@danielhochman @dschaller
Update frontend/packages/core/src/stories/horizontal-rule.stories.tsx
1091678 
Co-authored-by: Derek <dschaller@users.noreply.github.com>
@dschaller
Copy link
Contributor

dschaller commented Dec 1, 2020 •
edited
Loading

I'm not seeing children show up as a control in the without text story even with the export

@danielhochman
Copy link
Collaborator Author

afaict storybook filters out the children prop unless you make it an explicit control of some kind

@danielhochman danielhochman merged commit d1ec5f5 into UIV2 Dec 2, 2020
@danielhochman danielhochman deleted the ui-v2-horizontalRule branch December 2, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschaller dschaller dschaller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielhochman @dschaller