ui v2: text field #701
Merged
ui v2: text field #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d1d72ad to
120bcbf
Compare
120bcbf to
abf84ab
Compare
dschaller
reviewed
Nov 30, 2020
Co-authored-by: Derek <dschaller@users.noreply.github.com>
dschaller
reviewed
Dec 1, 2020
frontend/packages/core/src/Input/stories/text-field.stories.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
+100
to
+102
| | "onChange" | ||
| | "onFocus" | ||
| | "onKeyDown" |
There was a problem hiding this comment.
Is it worth having both onChange and onKeyDown? I'm trying to think of a use case where someone would want to specify two different handlers
There was a problem hiding this comment.
you're using onKeyDown in the resolver so i kept it, wasn't sure of implication of changing it and didn't want to change interfaces beyond style props
There was a problem hiding this comment.
👍 we should figure out a single callback but it can be done in a separate PR
dschaller
reviewed
Dec 1, 2020
dschaller
reviewed
Dec 1, 2020
dschaller
approved these changes
Dec 1, 2020
Co-authored-by: Derek <dschaller@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement new text field design with the exception of the "clear" control, which requires some more though and potentially refactoring to standardize on controlled vs uncontrolled components.
Testing Performed
See stories.