Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI V2: header #696
UI V2: header #696
Changes from all commits
5ee350e
ef2b910
3c62662
d441779
9b60034
2dc5668
851a2d4
94a88de
e4e4d5f
3002540
368e4ed
a02d5db
5ebea1b
017214b
58e9c01
d3e84c8
a6f6187
e42ba85
8e350d0
041f200
a90ffc3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be useful to have a notifications story so we can test the whole component (e.g. the popper and such) in isolation from the header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed up a notifications story. We won't see the popper b/c we don't have menu items but we can test the hover/pressed states in isolation.
RE: #696 (comment), do you mean a simple interface like
text: string
? was thinking we'd implement the menu in the future. but if we're planning to use the avatar menu design, we can conditionally render a menu if there are items to show. lmk what you'd prefer.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! I was thinking that we could have an interface for the component where it takes in the notifications that we want to render. I know we don't have designs for this yet so feel free to punt but ideally we pass in notifications that would allow us to test the component. Not blocking at this point but something to keep in mind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay got it! will leave a to-do, I'll follow up to add an interface. I think the metadata table interface would be a good one to pattern