ui v2: checkbox #686
Merged
ui v2: checkbox #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9bbd2e6 to
691da03
Compare
scarlettperry
commented
Dec 7, 2020
danielhochman
approved these changes
Dec 7, 2020
| @@ -1,4 +1,6 @@ | |||
| import React from "react"; | |||
There was a problem hiding this comment.
notice the name prop doesn't appear in storybook unless the import is like this
Suggested change
| import React from "react"; | |
| import * as React from "react"; |
Comment on lines
+53
to
+55
| props => ({ | ||
| border: props["data-disabled"] ? "1px solid #e7e7ea" : "1px solid #6e7083", | ||
| }) |
There was a problem hiding this comment.
this could be styled from the parent without having to plumb props. IMO it's cleaner but we haven't written a style guide or made firm decisions here so it can be left as-is.
|
how will we render the 16px variant? |
was thinking we could pass a size prop to the checkbox and toggle the width/height? would also have to make sure the icon adjusts accordingly. will add a to-do and follow up on that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR
design is restyling the checkbox, so for now, added the design for what's highlighted in the dotted border.
Testing Performed
storybook