remove sns stuff from gateway #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
|
testing in staging and yes it does indeed still work |
|
/ptal #dev-console |
miguelmolina95
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is to remove the stuff from gateway that is writing to the sns topic. The sns topic is used by sqs in the legacy worker to pull the messages. It is how the gateway and the legacy worker communicate. Since legacy worker is being deleted, we don't need to send these messages anymore. The next step after this is to delete the SQS stuff as well.
Note that this is not deleting the audit jobs stuff, since we still need that, even after legacy is deleted. That is in the temporal worker.