use simple path for cloning in adhoc flow #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -112,6 +119,10 @@ func (g *RepoFetcher) generateDirPath(repoName string) string { | |||
| return filepath.Join(g.DataDir, workingDirPrefix, repoName, uuid.New().String()) | |||
| } | |||
|
|
|||
| func (g *RepoFetcher) GenerateSimpleDirPath(repoName string) string { | |||
There was a problem hiding this comment.
I recommend against exposing functions publicly when it can be avoided
There was a problem hiding this comment.
To test it wouldn't we have to put it in the same package then? Since they are in separate packages I wasn't sure how to make a test unless its exposed
There was a problem hiding this comment.
You can create a unit test against running Fetch with the new optional field you've created and validate that the generated path matches what you expected.
samrabelachew
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we don't need to use the uuid and all that stuff since we only have 1 repo on our batch pod. To actually use this func, in the other PR we will pass in the option of simplePath = true