Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error checking to job url generator. #137

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

nishkrishnan
Copy link
Contributor

Fixes a bug where project name is nil and in general we should always be checking any errors and not panicking.

Copy link

@Aayyush Aayyush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@nishkrishnan nishkrishnan merged commit c2c42f9 into release-v0.17.1-lyft.1 Oct 13, 2021
@nishkrishnan nishkrishnan deleted the nish/fix-nil-deref branch October 13, 2021 18:15
Aayyush pushed a commit that referenced this pull request Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants