Support underscores in Markdown URLs #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, `pulldown_cmark` produces multiple text events if it detects an `_`. That is for performance reasons. More information [here](See pulldown-cmark/pulldown-cmark#146). The correct way to handle this is by using the [`TextMergeStream`](https://docs.rs/pulldown-cmark/latest/pulldown_cmark/utils/struct.TextMergeStream.html) helper-struct, which provides an iterator that merges consecutive `Event::Text` events into one. With this, we can correctly parse links like `http://example.com/_/foo`. Fixes #1529
8dbaf45 to
cab3d3e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default,
pulldown_cmarkproduces multiple text events if it detects an_. That is for performance reasons. More information [here](See pulldown-cmark/pulldown-cmark#146).The correct way to handle this is by using the
TextMergeStreamhelper-struct, which provides an iterator that merges consecutiveEvent::Textevents into one.With this, we can correctly parse links like
http://example.com/_/foo.Fixes #1529