Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

404 when checking youtube-nocookie url #1562

Closed
mattr-rsolomon opened this issue Nov 8, 2024 · 3 comments · Fixed by #1563
Closed

404 when checking youtube-nocookie url #1562

mattr-rsolomon opened this issue Nov 8, 2024 · 3 comments · Fixed by #1563
Assignees
@mre
Labels
bug Something isn't working

Comments

@mattr-rsolomon
Copy link

Hi,
Youtube links in no cookie url form are returning 404. I understand from the previous Youtube related issues that Youtube URLs have their quirks, but wanted to ask if there is a way to properly handle youtube no-cookie URLs ?

thank you 🙌

<!-- testfile.html -->
<html>
  <body>
    <div>
      <iframe src="https://www.youtube-nocookie.com/embed/BIguvia6AvM" id="widget2"></iframe>
      <iframe src="https://www.youtube.com/watch?v=BIguvia6AvM"></iframe>
    </div>
  </body>
</html>

lychee --version
lychee 0.17.0

lychee ./testfile.html --verbose
     [404] https://www.youtube-nocookie.com/embed/BIguvia6AvM
     [200] https://www.youtube.com/watch?v=BIguvia6AvM
@mre mre self-assigned this Nov 8, 2024
@mre mre added the bug Something isn't working label Nov 8, 2024
@mre
Copy link
Member

mre commented Nov 8, 2024

Thanks, yeah, that's a bug.
We also don't handle /embed/ URLs as well, so that's two bugs. 😆

mre added a commit that referenced this issue Nov 8, 2024
@mre
Add quirks support for youtube-nocookie.com and youtube embed URLs
98f1d32 
Fixes #1562
@mre mre mentioned this issue Nov 8, 2024
Merged
@mre mre closed this as completed in #1563 Nov 8, 2024
@mre
Copy link
Member

mre commented Nov 8, 2024

Should be fixed; thanks for reporting!

@mattr-rsolomon
Copy link
Author

that was quick! thank you for resolving the issue!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mre mre

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add quirks support for youtube-nocookie.com and youtube embed URLs lycheeverse/lychee
2 participants
@mre @mattr-rsolomon