Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better handling of unknown symmetry representations #10

Merged
merged 1 commit into from
Mar 10, 2024
Merged

better handling of unknown symmetry representations #10

merged 1 commit into from
Mar 10, 2024

Conversation

lxvm
Copy link
Owner

@lxvm lxvm commented Mar 10, 2024

This pr makes sure that the correct result is returned for integrands that have unknown symmetry representations by returning a result computed with FBZ. This is a slow-down but we should always aim to be correct. Some of the heuristics that scalar integrands have a trivial representation may be incorrect if that scalar is a matrix element of some non-trivial operator, but requiring declaring a symmetry representation would be breaking.

Copy link

codecov bot commented Mar 10, 2024

Codecov Report

Attention: Patch coverage is 70.90909% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 86.57%. Comparing base (6b8c8df) to head (c02b526).

Files Patch % Lines
src/brillouin.jl 66.66% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   87.29%   86.57%   -0.73%     
==========================================
  Files          15       15              
  Lines        1220     1266      +46     
==========================================
+ Hits         1065     1096      +31     
- Misses        155      170      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lxvm lxvm merged commit 65e8d34 into main Mar 10, 2024
7 of 9 checks passed
@lxvm lxvm deleted the sym branch March 16, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant