Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File copy progress windows are not picked up #1466

Closed
adarshvadwitiya opened this issue Apr 5, 2022 · 12 comments
Closed

File copy progress windows are not picked up #1466

adarshvadwitiya opened this issue Apr 5, 2022 · 12 comments
Labels
bug Something isn't working

Comments

@adarshvadwitiya
Copy link

Describe the bug

AltTab doesn't pick up file copy progress windows

Screenshots
This is what my preferences look like:
SCR-20220405-na7

SCR-20220405-naf

Steps to reproduce the bug

  1. Have a file copy progress window open
  2. Click CMD+Tab
  3. All other windows show up except the file copy progress window
@adarshvadwitiya adarshvadwitiya added the bug Something isn't working label Apr 5, 2022
@lwouis
Copy link
Owner

lwouis commented Apr 8, 2022

Are these really windows though? AltTab has to filter out things like dialogs and HUDs. It may be that Finder declares those as such and not as windows, in which case AltTab would rightfully filter them out.

Someone should check how they are declared at the technical level

@joostin81
Copy link

I believe HyperSwitch shows file copy progress windows but not dialogs/HUDs

@XInTheDark
Copy link

@lwouis https://apple.stackexchange.com/a/432476
According to this, the file copy window should theoretically indeed be declared as a window.

@lwouis
Copy link
Owner

lwouis commented Jun 24, 2022

Anyone knows a trick to spawn such window and have it stay for a little while? My SSD is really fast, and most file copies don't spawn a window, or very briefly.

@adarshvadwitiya
Copy link
Author

adarshvadwitiya commented Jun 25, 2022

Not sure if this’ll help but you can create large dummy files using mkfile <size>G your-file-name. So if you move that to an external drive, the window should stick around for a while

@XInTheDark
Copy link

My SSD is really fast, and most file copies don't spawn a window, or very briefly.

What SSD do you use? I wanna get one 😂

@lwouis
Copy link
Owner

lwouis commented Jun 26, 2022

The issue I think is that on macOS file-system, moving or even copying a large file is just creating/moving a file descriptor. So it's instant. I was able to get a Finder copy window by copying a folder with lots of subfolders (this repo actually).

So the issue is that the Finder copy window doesn't pass the height > 100px check. On my system, in my language (English), its height is 69px.

I'm not sure how to deal with this situation. I explored the heuristic in #456 in the past. Here is an example of an app for which we need to filter out windows smaller than 100px: #562.

What I could do is add a whitelist for Finder: if it's Finder, we show windows regardless of their size. However it doesn't seem ideal as other apps could have legitimate small windows. Yet other apps have small non-windows.

What to do?

@XInTheDark
Copy link

What I could do is add a whitelist for Finder: if it's Finder, we show windows regardless of their size. However it doesn't seem ideal as other apps could have legitimate small windows. Yet other apps have small non-windows.

Adding a whitelist for Finder would be great.

I don't really understand why there needs to be a height filter, though; does it serve any real purpose in use?

@adarshvadwitiya
Copy link
Author

adarshvadwitiya commented Jun 27, 2022

The issue I think is that on macOS file-system, moving or even copying a large file is just creating/moving a file descriptor. So it's instant. I was able to get a Finder copy window by copying a folder with lots of subfolders (this repo actually).

So the issue is that the Finder copy window doesn't pass the height > 100px check. On my system, in my language (English), its height is 69px.

I'm not sure how to deal with this situation. I explored the heuristic in #456 in the past. Here is an example of an app for which we need to filter out windows smaller than 100px: #562.

What I could do is add a whitelist for Finder: if it's Finder, we show windows regardless of their size. However it doesn't seem ideal as other apps could have legitimate small windows. Yet other apps have small non-windows.

What to do?

A white list seems like the way to go because small (<100px) progress windows appear not just for cut, copy & paste but for archiving & unarchiving, file upload & download etc.

@lwouis
Copy link
Owner

lwouis commented Jun 27, 2022

I don't really understand why there needs to be a height filter, though; does it serve any real purpose in use?

I just gave an example above 😅

Here is an example of an app for which we need to filter out windows smaller than 100px: #562.

@lwouis
Copy link
Owner

lwouis commented Jun 27, 2022

A white list seems like the way to go because small (<100px) progress windows appear not just for cut, copy & paste but for archiving & unarchiving, file upload & download etc.

I'm thinking maybe i could whitelist all apps from Apple (i.e. bundleId starts with com.apple). But that may actually be too much. Apple sometimes doesn't respect its own standard/tech. Maybe Finder is enough?

I could also reverse the approach: let any app show small windows, and as users complain (e.g. intellij), i either redirect these users to these apps customer support, or i add a blacklist to prevent specific windows to show for specific apps.

Actually i think i'll do that

@lwouis
Copy link
Owner

lwouis commented Aug 25, 2022

I have a local commit which fixes this issue. I'm waiting for other changes to bundle those into a release.

@lwouis lwouis closed this as completed in c78481b Oct 14, 2022
lwouis pushed a commit that referenced this issue Oct 14, 2022
# [6.47.0](v6.46.1...v6.47.0) (2022-10-14)

### Bug Fixes

* alt-tab would show on the wrong screen (closes [#2003](#2003)) ([b72c4db](b72c4db))
* discover windows when switching spaces ([#1324](#1324)) ([9c26d54](9c26d54))
* shortcut tabs right margin ([d207f86](d207f86))
* show finder file copy windows (closes [#1466](#1466)) ([c78481b](c78481b))
* wrap thumbnail buttons when needed ([ea05c03](ea05c03))

### Features

* improve many localizations and add romanian ([71f1609](71f1609))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants