Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcut triggers even if extra modifier keys are pressed #133

Closed
lwouis opened this issue Feb 5, 2020 · 0 comments
Closed

Shortcut triggers even if extra modifier keys are pressed #133

lwouis opened this issue Feb 5, 2020 · 0 comments
Labels
bug Something isn't working
Milestone
v4

Comments

@lwouis
Copy link
Owner

lwouis commented Feb 5, 2020

From discussion #45 (comment)

The app seems to capture X+hotkeys, when more typical behaviour is only to respond to hotkeys only. e.g. if I've set ALT+TAB as the hotkey for this, and I've SHIFT+ALT+TAB as a hotkey to play/pause Spotify, alt-tab (the app) still gets invoked in the second scenario. This behaviour is in contrast to most other apps including e.g. HyperSwitch

This behavior has been there from day 1 I believe. The keyboard events checks we do are "at least these keys are pressed", not "exactly these keys are pressed". I'll open a ticket to track that issue. As soon as ShortcutRecorder implements the ticket I opened, I will work on #72. ShortcutRecorder has exact matching so it will close this issue as well.
@lwouis lwouis added the bug Something isn't working label Feb 5, 2020
@lwouis lwouis mentioned this issue Feb 12, 2020
Closed
@lwouis lwouis added this to the v4 milestone Mar 11, 2020
lwouis added a commit that referenced this issue Apr 1, 2020
@lwouis
feat: more flexible shortcuts (closes #72)
f6e4078 
closes #50, closes #125, closes #133
lwouis added a commit that referenced this issue Apr 1, 2020
@lwouis
feat: more flexible shortcuts (closes #72)
76a1a39 
closes #50, closes #125, closes #133
lwouis added a commit that referenced this issue Apr 2, 2020
@lwouis
feat: more flexible shortcuts (closes #72)
3eefe75 
closes #50, closes #125, closes #133
@lwouis lwouis closed this as completed in 5eade75 Apr 2, 2020
lwouis pushed a commit that referenced this issue Apr 2, 2020
@semantic-release-bot
chore(release): 3.3.0 [skip ci]
4915b57 
# [3.3.0](v3.2.1...v3.3.0) (2020-04-02)

### Bug Fixes

* .strings encoding should be utf-8 ([7109b08](7109b08))
* avoid having multiple login items ([65816a2](65816a2))
* preferences would not be live (closes [#188](#188)) ([d5b74a1](d5b74a1)), closes [#194](#194)
* simpler/better window focus ([574a640](574a640))

### Features

* localized in 5 new languages ([48bb3df](48bb3df))
* more flexible shortcuts (closes [#72](#72)) ([5eade75](5eade75)), closes [#50](#50) [#125](#125) [#133](#133)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v4
Development

No branches or pull requests
1 participant
@lwouis