Including "lvgl.h" if LV_LVGL_H_INCLUDE_SIMPLE is defined. #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When LV_LVGL_H_INCLUDE_SIMPLE is not defined (the default) then `"lvgl/lvgl.h"` is included, else `"lvgl.h"` is included. This is for other build systems (like PlatformiIO) which setup build paths differently than esp-idf. More info in issue lvgl#220.
|
Hi, Thanks for the PR, this seems fine to me, I will read #220 tomorrow, I don't have a lot of experience using Platformio (only used it for a blinky project more than a year ago). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When LV_LVGL_H_INCLUDE_SIMPLE is not defined (the default) then
"lvgl/lvgl.h"is included, else"lvgl.h"is included.This is for other build systems (like PlatformiIO) which setup
build paths differently than esp-idf. More info in issue #220.
This approach is identical to that used by https://github.com/lvgl/lv_drivers.