Enable support for BUILD_SHARED_LIBS on Windows #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable
CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS
used to supportBUILD_SHARED_LIBS
works fine for all symbols, except static/global variable (see https://cmake.org/cmake/help/latest/prop_tgt/WINDOWS_EXPORT_ALL_SYMBOLS.html and https://www.kitware.com/create-dlls-on-windows-without-declspec-using-new-cmake-export-all-feature/).For this reason, the global symbols need to be explicitly exported via
__declspec(dllexport)
and__declspec(dllimport)
, that are added via aXLinkExport.h
header generated by thegenerate_export_header
CMake function.Without this fix, linking an executable against the
XLink
shared library on Windows fails with error: