Fix LIBUSB_INCLUDE_DIR value when using XLINK_LIBUSB_SYSTEM #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Windows failure is unrelated and related to luxonis/depthai-core#1037 and cpp-pm/hunter#747 . |
themarpe
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, with
XLINK_LIBUSB_SYSTEMset toON~ iflibusbwas installed in<install_prefix>, theLIBUSB_INCLUDE_DIRvariable contained the path<install_prefix>\include\libusb-1.0`.However, the code itself includes the libusb headers as
#include <libusb-1.0\libusb.h>, and so using<install_prefix>\include\libusb-1.0resulted in errors related to the fact thatlibusb-1.0\libusb.hcould not be found.After this PR,
LIBUSB_INCLUDE_DIRvariable will contain the path<install_prefix>\include, ensuring that the correct include header is passed to the pre-processor.I guess that this problem was never detected as the
<install_prefix>\includeof libusb was in the header path of the system, and so the compilation ended up well anyhow, but the compilation fails if the external libusb used is not installed in the system prefix.