fix(runtime-core): disable deps collection in watch callbacks (vuejs#…

…2728)
luwuer · Feb 26, 2021 · 21c0dfd · 21c0dfd
1 parent d87bc2b
commit 21c0dfd
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/packages/runtime-core/src/apiWatch.ts b/packages/runtime-core/src/apiWatch.ts
@@ -5,7 +5,9 @@ import {
   Ref,
   ComputedRef,
   ReactiveEffectOptions,
-  isReactive
+  isReactive,
+  pauseTracking,
+  resetTracking
 } from '@vue/reactivity'
 import { SchedulerJob, queuePreFlushCb } from './scheduler'
 import {
@@ -249,6 +251,9 @@ function doWatch(
       // watch(source, cb)
       const newValue = runner()
       if (deep || forceTrigger || hasChanged(newValue, oldValue)) {
+        // ref #2728
+        // disable deps collection in watch callbacks
+        pauseTracking()
         // cleanup before running cb again
         if (cleanup) {
           cleanup()
@@ -259,6 +264,7 @@ function doWatch(
           oldValue === INITIAL_WATCHER_VALUE ? undefined : oldValue,
           onInvalidate
         ])
+        resetTracking()
         oldValue = newValue
       }
     } else {