Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #561, uninitialised memory access #562

Merged
merged 3 commits into from
Aug 8, 2021
Merged

fix #561, uninitialised memory access #562

merged 3 commits into from
Aug 8, 2021

Conversation

zhaozg
Copy link
Member

@zhaozg zhaozg commented Aug 8, 2021

No description provided.

@squeek502
Copy link
Member

squeek502 commented Aug 8, 2021

This will fix the uninitialized reads, but is it actually okay for luv_cfpcall to be returning -1 when there are 0 values returned by the work_cb function?

luv/src/work.c

Line 96 in 727c6e4

i = luv_cfpcall(L, i, LUA_MULTRET, 0);

(more details at #561 (comment))

@zhaozg
Copy link
Member Author

zhaozg commented Aug 8, 2021

This will fix the uninitialized reads, but is it actually okay for luv_cfpcall to be returning -1 when there are 0 values returned by the work_cb function?

that because vm stack index(get_top after push err_funcs) not balance, fixed in
2d685c3

thank you very muach.

@zhaozg zhaozg merged commit c699ab4 into luvit:master Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants