Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid EqPolynomial when only for evals. #157

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Avoid EqPolynomial when only for evals. #157

merged 2 commits into from
Dec 4, 2023

Conversation

porcuquine
Copy link
Contributor

This eliminates some unnecessary cloning caused by unused intermediate EqPolynomials.

@porcuquine porcuquine mentioned this pull request Dec 1, 2023
Merged
@huitseeker
refactor: a few more instances of EqPolynomial::evals_from_points
bfe39dd 
- in `multilinear.rs` and `ipa_pc.rs`, replaces the previous method `EqPolynomial::new(r.to_vec()).evals()` with a more efficient `EqPolynomial::evals_from_points(r)`.
huitseeker
huitseeker approved these changes Dec 3, 2023
View reviewed changes
Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a ton of sense. I added a commit with 4 other instances.

Note (just fyi): this can also be addressed by ref_cast, a technique I use in #145

@porcuquine
Copy link
Contributor Author

I'll look into reworking with ref_cast but merging this now to simplify dev for all.

@porcuquine porcuquine merged commit 5b7397e into batched_spartan Dec 4, 2023
@porcuquine porcuquine deleted the just-evals branch December 4, 2023 19:26
@huitseeker huitseeker mentioned this pull request Dec 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huitseeker huitseeker huitseeker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@porcuquine @huitseeker