SuperNova: Improve circuit #120

adr1anh · 2023-11-14T18:11:44Z

This PR fixes some minor annoyances in the SuperNova circuit and adds documentation.

Compute number of RO inputs for public output via a function
Compute instance selector vector from last_augmented_circuit_index in alloc_witness
- Reuse the selector across the base and non-base branches.
Add comments

src/supernova/circuit.rs

src/supernova/mod.rs

src/supernova/test.rs

src/supernova/utils.rs

porcuquine

I left a couple comments about the possibility of an out-of-range index when creating selectors of length one, and about the test that would have caught it.

src/supernova/utils.rs

src/gadgets/utils.rs

adr1anh

Thank you all for the useful comments, I hope this adresses everything. I think it needs a rebase, so I'll wait for confirmation that all points have been adressed.

adr1anh · 2023-11-16T13:45:11Z

On second thought, I think removing the unused functions should be handled by another PR. They are used by the tests, namely those using TestROM. For now, I'd suggest reverting the latest commit and filing an issue to address the dead code separately. WDYT @huitseeker ?

The fact that the latest commit failed worries me a bit. Replacing the bit computation with the new selector gadget should not have changed the behavior.
The failure happens in the last iteration, since the program_counter is the next one computed by the function, and it does not belong in the ROM. Therefore, I'm not entirely convinced the circuit as a whole is correct, at least as it was before the latest change. For instance, I see that
constrain_augmented_circuit_index is called in SquareCircuit but not in CubicCircuit.
While it is only there for testing purposes, I'm worried someone might copy it for their own circuit. Do you think a more thorough audit of this circuit is warranted ?

huitseeker

LGTM!

src/supernova/test.rs

huitseeker · 2023-11-17T14:50:41Z

src/supernova/utils.rs

 ///
-/// If `target_index` is out of bounds, the circuit will be unsatisified.
+/// This function assumes `selector_vec` has been properly constrained", i.e. that exactly one entry is equal to 1.  


Nit: dangling double quote

porcuquine · 2023-11-17T17:43:21Z

On second thought, I think removing the unused functions should be handled by another PR. They are used by the tests, namely those using TestROM. For now, I'd suggest reverting the latest commit and filing an issue to address the dead code separately. WDYT @huitseeker ?

The fact that the latest commit failed worries me a bit. Replacing the bit computation with the new selector gadget should not have changed the behavior. The failure happens in the last iteration, since the program_counter is the next one computed by the function, and it does not belong in the ROM. Therefore, I'm not entirely convinced the circuit as a whole is correct, at least as it was before the latest change. For instance, I see that constrain_augmented_circuit_index is called in SquareCircuit but not in CubicCircuit. While it is only there for testing purposes, I'm worried someone might copy it for their own circuit. Do you think a more thorough audit of this circuit is warranted ?

I agree with your analysis.

porcuquine

Great work.

Comments

Fix test

This backports the following Arecibo PRs: - #2 - #3 - #10 - #16 - #23 - #30 - #28 - #41 - #45 - #50 - #56 - #51 - #72 - #92 - #95 - #97 - #101 - #110 - #106 - #112 - #114 - #119 - #120 - #127 - #123 - #131 - #174 - #175 - #182 Co-authored-by: WYATT <wyattbenno@gmail.com> Co-authored-by: Hanting Zhang <hantingz@usc.edu> Co-authored-by: Ming <hero78119@gmail.com> Co-authored-by: porcuquine <porcuquine@users.noreply.github.com> Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com> Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com> Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>

This implements [Supernova](https://eprint.iacr.org/2022/1758), allowing: - a 'pay-as-you-go' cost structure for folding operations, through the SuperNova folding scheme, - a final SNARK that efficiently compresses an instance of this folded proof, through batching techniques. References: - the [blog post](https://blog.lurk-lang.org/posts/arecibo-supernova/#technical-release-note-supernova-protocol-integration-into-nova) goes into our construction, and links to two more specialized notes on [the `CompressedSNARK` for Supernova](https://hackmd.io/@adr1anh/BJw1g0aBT) along with our variant of the [public input padding issue](https://hackmd.io/@adr1anh/Sy08YaVBa). - the Readme at `src/supernova/Readme.md` This backports the following Arecibo PRs: - lurk-lang/arecibo#2 - lurk-lang/arecibo#3 - lurk-lang/arecibo#10 - lurk-lang/arecibo#16 - lurk-lang/arecibo#23 - lurk-lang/arecibo#30 - lurk-lang/arecibo#28 - lurk-lang/arecibo#41 - lurk-lang/arecibo#45 - lurk-lang/arecibo#50 - lurk-lang/arecibo#56 - lurk-lang/arecibo#51 - lurk-lang/arecibo#72 - lurk-lang/arecibo#92 - lurk-lang/arecibo#95 - lurk-lang/arecibo#97 - lurk-lang/arecibo#101 - lurk-lang/arecibo#110 - lurk-lang/arecibo#106 - lurk-lang/arecibo#112 - lurk-lang/arecibo#114 - lurk-lang/arecibo#119 - lurk-lang/arecibo#120 - lurk-lang/arecibo#127 - lurk-lang/arecibo#123 - lurk-lang/arecibo#131 - lurk-lang/arecibo#174 - lurk-lang/arecibo#175 - lurk-lang/arecibo#182 Co-authored-by: WYATT <wyattbenno@gmail.com> Co-authored-by: Hanting Zhang <hantingz@usc.edu> Co-authored-by: Ming <hero78119@gmail.com> Co-authored-by: porcuquine <porcuquine@users.noreply.github.com> Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com> Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com> Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>

adr1anh changed the title ~~Ah/sn_opt~~ SuperNova: Improve circuit Nov 14, 2023

arthurpaulino reviewed Nov 14, 2023

View reviewed changes

src/supernova/circuit.rs Outdated Show resolved Hide resolved

adr1anh force-pushed the ah/sn_opt branch from c920dae to c9a2688 Compare November 14, 2023 18:24

porcuquine reviewed Nov 14, 2023

View reviewed changes

src/supernova/mod.rs Show resolved Hide resolved

porcuquine reviewed Nov 14, 2023

View reviewed changes

src/supernova/test.rs Outdated Show resolved Hide resolved

porcuquine reviewed Nov 14, 2023

View reviewed changes

src/supernova/utils.rs Outdated Show resolved Hide resolved

porcuquine reviewed Nov 14, 2023

View reviewed changes

src/supernova/utils.rs Outdated Show resolved Hide resolved

porcuquine requested changes Nov 14, 2023

View reviewed changes

adr1anh marked this pull request as ready for review November 15, 2023 15:40

porcuquine reviewed Nov 15, 2023

View reviewed changes

src/supernova/utils.rs Outdated Show resolved Hide resolved

huitseeker reviewed Nov 16, 2023

View reviewed changes

src/gadgets/utils.rs Show resolved Hide resolved

src/gadgets/utils.rs Show resolved Hide resolved

adr1anh commented Nov 16, 2023

View reviewed changes

adr1anh force-pushed the ah/sn_opt branch from cc2ccf2 to c14fc3f Compare November 16, 2023 15:53

adr1anh mentioned this pull request Nov 16, 2023

SuperNova: Fix ROM test and remove dead code #127

Merged

adr1anh requested a review from porcuquine November 17, 2023 10:37

huitseeker approved these changes Nov 17, 2023

View reviewed changes

porcuquine approved these changes Nov 17, 2023

View reviewed changes

adr1anh added 7 commits November 17, 2023 20:12

Function computing num RO inputs

d8b313d

Use instance selector

fb1a1c5

Comments

Docstrings

3f84018

More efficient selector computation

bcfc465

Fix test

fix lints

a61c5e9

Remove special case in selector

4c5397f

Fix digest computation

05c9c5a

adr1anh force-pushed the ah/sn_opt branch from f58ffbe to 05c9c5a Compare November 17, 2023 19:13

adr1anh enabled auto-merge November 17, 2023 19:17

adr1anh added this pull request to the merge queue Nov 17, 2023

Merged via the queue into lurk-lang:dev with commit 62ed491 Nov 17, 2023

adr1anh deleted the ah/sn_opt branch November 17, 2023 19:30

huitseeker added the supernova label Nov 29, 2023

huitseeker mentioned this pull request Dec 18, 2023

feat: implement SuperNova microsoft/Nova#283

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SuperNova: Improve circuit #120

SuperNova: Improve circuit #120

adr1anh commented Nov 14, 2023 •

edited

Loading

porcuquine left a comment

adr1anh left a comment

adr1anh commented Nov 16, 2023 •

edited

Loading

huitseeker left a comment

huitseeker Nov 17, 2023

porcuquine commented Nov 17, 2023

porcuquine left a comment

SuperNova: Improve circuit #120

SuperNova: Improve circuit #120

Conversation

adr1anh commented Nov 14, 2023 • edited Loading

porcuquine left a comment

Choose a reason for hiding this comment

adr1anh left a comment

Choose a reason for hiding this comment

adr1anh commented Nov 16, 2023 • edited Loading

huitseeker left a comment

Choose a reason for hiding this comment

huitseeker Nov 17, 2023

Choose a reason for hiding this comment

porcuquine commented Nov 17, 2023

porcuquine left a comment

Choose a reason for hiding this comment

adr1anh commented Nov 14, 2023 •

edited

Loading

adr1anh commented Nov 16, 2023 •

edited

Loading