Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚨 Performance regression in #238 #248

Closed
github-actions bot opened this issue Jan 9, 2024 · 1 comment · Fixed by #253
Closed

🚨 Performance regression in #238 #248

github-actions bot opened this issue Jan 9, 2024 · 1 comment · Fixed by #253
Labels
automated issue P-Performance

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Regression >= $1.05 found during merge of: #238
Commit: 85c04b3
Triggered by: https://github.com/lurk-lab/arecibo/actions/runs/7455258487
@huitseeker
Copy link
Contributor

huitseeker commented Jan 9, 2024 •
edited
Loading

@samuelburnham The noise threshold of 1.05 is probably a bit low, and within the classic Nova error margin (which is wide). 1.3 seems more reasonable.

Also $1.05, LOL.

This was referenced Jan 10, 2024
Merged
Closed
@samuelburnham samuelburnham mentioned this issue Jan 10, 2024
Merged
@samuelburnham samuelburnham linked a pull request Jan 10, 2024 that will close this issue
Refactor Supernova benchmarks and config for CI #253
Merged
huitseeker pushed a commit to huitseeker/arecibo that referenced this issue Jan 14, 2024
@srinathsetty
Reduce hashing costs with a power polynomial in ppsnark (lurk-lang#248)
5b3ce99 
* use eq polynomial emulated via power polynomial, to reduce hashing costs

* update version

* add missing file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
automated issue P-Performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Supernova benchmarks and config for CI samuelburnham/arecibo
1 participant
@huitseeker