Web deploy prerequisites #1851

sabau · 2019-01-17T17:22:16Z

Description:

reduce bundle size by optimizing few imports
reduce lodash/fp dependency (a single usage for a whole library)
change build command as yarn pack is reserved and does not call webpack

Deployment of nodes followup (I won't do all this in the first PR, but we know it's possible and we can specify those details to the SRE team next call)

My plan is to have two node types:

gaia in a Docker exposing RPC port
gaiacli in another Docker, exposing the rest server, but pointing to the first machine of type gaia
Eventually an nginx or APIGateway, the chapest solution will win 🎉
Is possible, BUT the genesis file should be on both node types

In this way we will be able to spin up gaia nodes as hell and just one gaiacli node pointing to (let's say) the first gaia node, so the gaiacli node can scaleup indipendently if he receives burst of requests, but the real nodes are always the same

gaiacli [command] --node=IP:PORT

❤️ Thank you!

Added entries in CHANGELOG.md with issue # and GitHub username
Reviewed Files changed in the github PR explorer

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

codecov · 2019-01-21T10:32:05Z

Codecov Report

Merging #1851 into develop will increase coverage by 0.02%.
The diff coverage is 96.87%.

@@             Coverage Diff             @@
##           develop    #1851      +/-   ##
===========================================
+ Coverage       95%   95.03%   +0.02%     
===========================================
  Files          119      119              
  Lines         2565     2558       -7     
  Branches       120      120              
===========================================
- Hits          2437     2431       -6     
+ Misses         118      117       -1     
  Partials        10       10

Impacted Files	Coverage Δ
app/src/renderer/vuex/modules/send.js	`100% <ø> (ø)`	⬆️
app/src/renderer/vuex/modules/connection.js	`92.45% <ø> (-0.14%)`	⬇️
app/src/renderer/vuex/modules/user.js	`100% <ø> (ø)`	⬆️
app/src/renderer/vuex/modules/wallet.js	`100% <ø> (ø)`	⬆️
app/src/renderer/vuex/store.js	`100% <100%> (ø)`	⬆️
...rc/renderer/components/common/TmSessionLoading.vue	`100% <100%> (ø)`	⬆️
app/src/renderer/vuex/modules/transactions.js	`76% <100%> (ø)`	⬆️
app/src/renderer/connectors/lcdClient.js	`100% <100%> (ø)`	⬆️
app/src/renderer/connectors/node.js	`100% <100%> (ø)`	⬆️
app/src/renderer/scripts/boot.js	`95.65% <95.65%> (ø)`
... and 1 more

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

…tes' into sabau/web/1833-deploy-prerequisites

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

…tes' into sabau/web/1833-deploy-prerequisites

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

package.json

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com> # Conflicts: # .circleci/config.yml # app/src/renderer/connectors/node.js # app/src/renderer/main.js # package.json # test/unit/specs/connectors/node.spec.js # webpack.renderer.config.js # yarn.lock

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

…loy-prerequisites

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

sabau · 2019-02-01T17:22:49Z

The coverage is a bit funny, I think it says that is not covered anymore since when I removed he side effect (main() was called for real once the file was imported and it was touching this function but was not tested for real)

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

Co-Authored-By: sabau <szabo.karoly.a@gmail.com>

.aws/first.sh

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

jbibla · 2019-02-08T20:28:20Z

.aws/first.sh

@@ -0,0 +1,67 @@
+#!/bin/bash


do we need to include .aws files? @cosmos/sre ?

those are used by the current (temporary) node setup on EC2, until the real network boot on merge is ready

jbibla · 2019-02-08T20:35:17Z

app/src/renderer/scripts/boot.js

+
+    // this will pass the state to Sentry when errors are sent.
+    // this would also sent passwords...
+    // Sentry.configureScope(scope => {


commented out?

left in as a warning to not do this. see the comment

webpack.renderer.config.js

faboweb · 2019-02-11T13:05:06Z

Re coverage: I think the router setup could be escaped via /* istanbul ignore next */ and the on route changed handler should be tested.

* custom image for voyager build / AWS deployment

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

.circleci/config.yml

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

…docker image and alias, we use docker-deploy instead Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

.aws/others.sh

cicle.run_deploy.sh

package.json

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

test/unit/specs/App.spec.js

faboweb · 2019-02-13T10:23:41Z

test/unit/specs/App.spec.js

@@ -72,4 +71,95 @@ describe(`App Start`, () => {
    expect(startApp).toHaveBeenCalled()
    expect(startApp.mock.calls[0][0]).toHaveProperty(`x`, 1)
  })
+
+  it(`Check the calls on VUE`, async () => {


I would have maybe just called the function and checked if it doesn't throw.

yeah I tried to test the real call but was taking a weird path to mock them, so I just counted the number of calls

Co-Authored-By: sabau <szabo.karoly.a@gmail.com>

reduce bundle size

016018e

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

sabau requested review from faboweb, fedekunze and jbibla as code owners January 17, 2019 17:22

sabau changed the base branch from develop to web January 17, 2019 17:22

sabau changed the title ~~[WIP] Web deploy prerequisites~~ [WIP] Web deploy prerequisites -> WEB Jan 17, 2019

sabau added 5 commits January 17, 2019 18:59

Trying to remove lcdMockClient from our production build

d3848ed

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

split per module, this will boost network in modern browsers

7b2b801

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

Merge branch 'web' into sabau/web/1833-deploy-prerequisites

46f4f20

add +e error flag for security circleci check

64c81d8

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

remove unnecessary test, mock removed from node

d64e66e

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

sabau added 10 commits January 21, 2019 11:32

test audit job

967ffb1

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

Undo audit job test

1edf21d

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

Merge remote-tracking branch 'origin/sabau/web/1833-deploy-prerequisi…

ac5e061

…tes' into sabau/web/1833-deploy-prerequisites

remove Low from security audit check

36f4120

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

WIP automation to deploy frontend and backend

27b8aa7

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

fix certificate names

1b67222

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

Merge branch 'web' into sabau/web/1833-deploy-prerequisites

95c9c0b

boot scripts, S3 to pass info and autofaucet stuff

f5ce8e7

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

Merge remote-tracking branch 'origin/sabau/web/1833-deploy-prerequisi…

1026a0c

…tes' into sabau/web/1833-deploy-prerequisites

working boot process

0a7feb4

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

jbibla reviewed Jan 25, 2019

View reviewed changes

package.json Outdated Show resolved Hide resolved

sabau and others added 7 commits January 25, 2019 18:23

progress on automation

05a2cd1

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

clean deploy

753fd41

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

route to voyager.ninja

7cc72f8

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

route to voyager.ninja

feaaca6

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

favicon, config and restore full lodash for a single instance using it

6c0cba7

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

Merge remote-tracking branch 'origin/develop' into sabau/web/1833-dep…

4a2bbcc

…loy-prerequisites

sabau added 2 commits February 1, 2019 16:53

fallback configuration to allow builder to choose their values

09c8d76

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

keep the old name, now is hardcoded on github

d45f655

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

sabau and others added 4 commits February 1, 2019 19:51

remove duplicated yarn upgrade, restore fixed version

163bbcf

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

wait for genesis from main node

0b87b33

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

Merge branch 'develop' into sabau/web/1833-deploy-prerequisites

081e394

Update app/src/renderer/vuex/store.js

70feb28

Co-Authored-By: sabau <szabo.karoly.a@gmail.com>

sabau commented Feb 7, 2019

View reviewed changes

.aws/first.sh Show resolved Hide resolved

subscribe logic

32d91e2

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

jbibla reviewed Feb 8, 2019

View reviewed changes

webpack.renderer.config.js Show resolved Hide resolved

mircea-c and others added 2 commits February 12, 2019 11:53

custom image for voyager build / AWS deployment (#1942)

200f406

* custom image for voyager build / AWS deployment

test startApp

ea4d09e

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

mircea-c previously approved these changes Feb 12, 2019

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

.circleci/config.yml Outdated Show resolved Hide resolved

.circleci/config.yml Outdated Show resolved Hide resolved

.circleci/config.yml Show resolved Hide resolved

test route guard

88f6b4a

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

sabau dismissed mircea-c’s stale review via 88f6b4a February 12, 2019 14:44

comment e2e code in circleci, in this moment is not used, remove aws …

5bb6b87

…docker image and alias, we use docker-deploy instead Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

fedekunze reviewed Feb 12, 2019

View reviewed changes

.aws/others.sh Show resolved Hide resolved

fedekunze reviewed Feb 12, 2019

View reviewed changes

cicle.run_deploy.sh Outdated Show resolved Hide resolved

fedekunze reviewed Feb 12, 2019

View reviewed changes

package.json Show resolved Hide resolved

sabau added 2 commits February 12, 2019 16:59

Document build command with parameters, remove deploy bash script

bb6bd6c

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

patch for cosmos-sdk new mandatory parameter

24ff2c4

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

faboweb reviewed Feb 13, 2019

View reviewed changes

test/unit/specs/App.spec.js Outdated Show resolved Hide resolved

faboweb reviewed Feb 13, 2019

View reviewed changes

Update test/unit/specs/App.spec.js

386e076

Co-Authored-By: sabau <szabo.karoly.a@gmail.com>

faboweb approved these changes Feb 13, 2019

View reviewed changes

faboweb merged commit 0b5ba5d into develop Feb 13, 2019

faboweb deleted the sabau/web/1833-deploy-prerequisites branch February 13, 2019 11:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Web deploy prerequisites #1851

Web deploy prerequisites #1851

sabau commented Jan 17, 2019 •

edited

Loading

codecov bot commented Jan 21, 2019 •

edited

Loading

sabau commented Feb 1, 2019

jbibla Feb 8, 2019

sabau Feb 12, 2019

jbibla Feb 8, 2019

faboweb Feb 11, 2019

faboweb commented Feb 11, 2019

faboweb Feb 13, 2019

sabau Feb 13, 2019

Web deploy prerequisites #1851

Web deploy prerequisites #1851

Conversation

sabau commented Jan 17, 2019 • edited Loading

codecov bot commented Jan 21, 2019 • edited Loading

Codecov Report

sabau commented Feb 1, 2019

jbibla Feb 8, 2019

Choose a reason for hiding this comment

sabau Feb 12, 2019

Choose a reason for hiding this comment

jbibla Feb 8, 2019

Choose a reason for hiding this comment

faboweb Feb 11, 2019

Choose a reason for hiding this comment

faboweb commented Feb 11, 2019

faboweb Feb 13, 2019

Choose a reason for hiding this comment

sabau Feb 13, 2019

Choose a reason for hiding this comment

sabau commented Jan 17, 2019 •

edited

Loading

codecov bot commented Jan 21, 2019 •

edited

Loading