Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(packages): introduce eslint-config-bananass #6

Merged
merged 70 commits into from
Jan 11, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
70 commits
Select commit Hold shift + click to select a range
b676fdc
chore: delete `.gitkeep` and create `package.json`
lumirlumir Dec 1, 2024
a28ba00
chore: update `package-lock.json`
lumirlumir Dec 1, 2024
8d65563
wip: create `eslint-possible-problems.js`
lumirlumir Dec 1, 2024
a9df4b4
wip: create `src/rules/index.js`
lumirlumir Dec 1, 2024
96a877d
wip: create `src/index.js`
lumirlumir Dec 1, 2024
c1c3474
wip: create `templates/jsdoc.md`
lumirlumir Dec 2, 2024
8f3d2a7
Merge branch 'main' into feat-eslint-config-bananass
lumirlumir Dec 2, 2024
2304653
wip: create `eslint-layout-formatting.js`
lumirlumir Dec 2, 2024
6f49dcd
wip
lumirlumir Dec 2, 2024
5b63cb5
Merge branch 'main' into feat-eslint-config-bananass
lumirlumir Dec 4, 2024
01e4900
wip
lumirlumir Dec 7, 2024
cfb02b0
wip
lumirlumir Dec 7, 2024
638140f
wip
lumirlumir Dec 7, 2024
76eddad
wip: update `package.json`
lumirlumir Dec 7, 2024
12a5b5b
wip: update `jsdoc.md`
lumirlumir Dec 7, 2024
96a53b5
wip: update `index.js`
lumirlumir Dec 7, 2024
e0eb42e
Merge branch 'main' into feat-eslint-config-bananass
lumirlumir Dec 7, 2024
c232b11
wip
lumirlumir Dec 7, 2024
cc36e27
Merge branch 'feat-eslint-config-bananass' of https://github.com/lumi…
lumirlumir Dec 7, 2024
ffcf980
wip: update `eslint-suggestions.js`
lumirlumir Dec 7, 2024
bd688d7
Merge branch 'main' into feat-eslint-config-bananass
lumirlumir Dec 23, 2024
4ee9c46
chore: update ESLint config package and dependencies
lumirlumir Dec 24, 2024
d164908
refactor: rename eslint config package and update paths
lumirlumir Dec 24, 2024
4923144
wip: update `package.json`
lumirlumir Dec 24, 2024
911ca91
docs: update code block syntax from `javascript` to `js`
lumirlumir Dec 24, 2024
b80a9f9
refactor: update JSDoc comments to use `@fileoverview` and add `expor…
lumirlumir Dec 24, 2024
81662df
wip: update airbnb-base link comments
lumirlumir Dec 24, 2024
e39ff9d
Merge branch 'main' of https://github.com/lumirlumir/npm-bananas into…
lumirlumir Dec 27, 2024
e45f9bb
refactor: update 'no-use-before-define' rule to allow classes and var…
lumirlumir Dec 27, 2024
1ec4957
wip: eslint-suggestions.js
lumirlumir Dec 27, 2024
0d4a445
wip: `eslint-suggestions.js`
lumirlumir Dec 28, 2024
27af400
wip: update comment in `eslint-possible-problems.js`
lumirlumir Dec 28, 2024
00ab4dd
wip: update `eslint-suggestions.js`
lumirlumir Dec 28, 2024
232f7fc
wip: update `eslint-suggestion.js`
lumirlumir Dec 30, 2024
6234083
docs: create `packages-eslint-config-bananass.ko.md`
lumirlumir Dec 31, 2024
e8c409e
wip: fix typo
lumirlumir Dec 31, 2024
7970639
Merge branch 'main' into feat-eslint-config-bananass
lumirlumir Dec 31, 2024
df4f88a
Merge branch 'main' into feat-eslint-config-bananass
lumirlumir Dec 31, 2024
276b448
wip: rules
lumirlumir Jan 5, 2025
bfad86c
Merge branch 'feat-eslint-config-bananass' of https://github.com/lumi…
lumirlumir Jan 5, 2025
6cd68af
wip: `eslint-suggestions.js`
lumirlumir Jan 5, 2025
8281ab9
docs: update `how-to-parse-input-value.ko.md`
lumirlumir Jan 5, 2025
f301650
wip: `eslint-suggestions.js`
lumirlumir Jan 6, 2025
742c30a
wip: update `index.js`
lumirlumir Jan 6, 2025
024d471
wip: update `recommended.js`
lumirlumir Jan 6, 2025
3e78b9d
docs: update docs
lumirlumir Jan 8, 2025
b36486e
wip
lumirlumir Jan 8, 2025
08e668d
Merge branch 'main' into feat-eslint-config-bananass
lumirlumir Jan 8, 2025
ef55135
wip: `stylistic-js.js`
lumirlumir Jan 8, 2025
b16a1f9
wip: update rules to `'off'` to follow `eslint-config-prettier`
lumirlumir Jan 9, 2025
63e6937
wip: update `recommended.js`
lumirlumir Jan 9, 2025
de9dd70
wip: `import-helpful-warnings.js`
lumirlumir Jan 9, 2025
1601a12
wip: `import-module-systems.js`
lumirlumir Jan 9, 2025
2ae823b
Merge branch 'main' into feat-eslint-config-bananass
lumirlumir Jan 9, 2025
ad7f552
wip: `import-static-analysis.js`
lumirlumir Jan 9, 2025
7285d23
Merge branch 'main' into feat-eslint-config-bananass
lumirlumir Jan 9, 2025
32eed9e
wip: update comments
lumirlumir Jan 9, 2025
a0b878b
Merge branch 'main' into feat-eslint-config-bananass
lumirlumir Jan 9, 2025
3835ef3
wip: `import-style-guide.js`
lumirlumir Jan 10, 2025
e92cf42
wip
lumirlumir Jan 10, 2025
0668ea1
wip
lumirlumir Jan 10, 2025
2db15f3
wip: `package.json`
lumirlumir Jan 10, 2025
b7d32b8
wip: rename
lumirlumir Jan 10, 2025
e259b95
wip: `import-static-analysis.js`
lumirlumir Jan 10, 2025
a75ed93
wip: `node.js`
lumirlumir Jan 10, 2025
1cdd7f2
Merge branch 'main' into feat-eslint-config-bananass
lumirlumir Jan 10, 2025
b9a33a7
wip: `node.js`
lumirlumir Jan 10, 2025
76e6dd7
wip: `node.js`
lumirlumir Jan 11, 2025
18ecb89
chore: update sync-client.yml
lumirlumir Jan 11, 2025
dbe333a
chore: unify build step names in lint and test workflows
lumirlumir Jan 11, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .eslintignore

This file was deleted.

20 changes: 0 additions & 20 deletions .eslintrc.js

This file was deleted.

8 changes: 2 additions & 6 deletions .github/sync-client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,6 @@ lumirlumir/lumirlumir-configs:
# ./
- source: ./.editorconfig
dest: ./configs/.editorconfig
- source: ./.eslintignore
dest: ./configs/.eslintignore
- source: ./.eslintrc.js
dest: ./configs/.eslintrc.js
- source: ./.gitattributes
dest: ./configs/.gitattributes
- source: ./.gitignore
Expand All @@ -71,7 +67,7 @@ lumirlumir/lumirlumir-configs:
dest: ./configs/CODE_OF_CONDUCT.ko.md
- source: ./LICENSE.md
dest: ./configs/LICENSE.md
- source: ./lint-staged.config.js
dest: ./configs/lint-staged.config.js
- source: ./VScode.code-workspace
dest: ./configs/VScode.code-workspace
- source: ./lint-staged.config.js
dest: ./configs/lint-staged.config.js
3 changes: 3 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,8 @@ jobs:
- name: Set up node_modules
run: npm ci

- name: Build
run: npm run build --if-present

- name: Lint
run: npm run lint
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- name: Set up node_modules
run: npm ci

- name: Build test
- name: Build
run: npm run build --if-present

- name: Test and test coverage
Expand Down
15 changes: 15 additions & 0 deletions docs/eslint.ko.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# APIs

코딩 테스트 관련 해서 자주 쓰이는 문법에 대한 규칙은 해제.

airbnb-base 보다 훨씬 느슨하다.

## Configuration

```js
const bananass = require('eslint-config-bananass');

module.exports = [
bananass.configs.recommended
];
```
4 changes: 1 addition & 3 deletions docs/how-to-parse-input-value.ko.md
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,7 @@ const inputParsed = input;
>
> `+input` 혹은 `parseInt(input)`을 사용하여 문자열 형태의 입력값을 숫자로 변환해 주어도 됩니다.
>
> 단, ESLint의 [`no-implicit-coercion`](https://eslint.org/docs/latest/rules/no-implicit-coercion) 규칙에서 권장하듯, 위에서 언급한 암묵적 타입 변환 방법 대신 `Number()` 함수를 사용하는 것이 좋습니다.
>
> 또한 `create-bananass-app`에 포함된 ESLint 규칙을 사용하고 있다면 `Number()` 함수를 사용하는 것을 권장하니 참고해 주세요!
> 단, ESLint의 [`no-implicit-coercion`](https://eslint.org/docs/latest/rules/no-implicit-coercion) 규칙에서 권장하듯, 위에서 언급한 암묵적 타입 변환 방법 대신 가능하면 `Number()` 함수를 사용하는 것이 좋습니다.

### 파싱 방법

Expand Down
491 changes: 491 additions & 0 deletions docs/packages-eslint-config-bananass.ko.md

Large diffs are not rendered by default.

8 changes: 8 additions & 0 deletions eslint.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
const bananass = require('eslint-config-bananass');

module.exports = [
{
ignores: ['**/build/', '**/.next/'],
},
bananass.configs.recommended,
];
2 changes: 1 addition & 1 deletion lint-staged.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ module.exports = {
'npx prettier --check',
'npx editorconfig-checker -config .editorconfig-checker.json',
],
'*.js': 'npx eslint',
'*.{js,mjs,cjs,jsx}': 'npx eslint',
'*.md': ['npx markdownlint', 'npx textlint -f pretty-error'],
};
Loading
Loading