Fixes for multiple splashscreens and AC. #61
Conversation
|
Checking the "Copyright" variable in the FileInfo might be a good way to improve the AutoDetecter in the future. |
+ also give mainwindowtitle instead of handle id in logger
Classes/Services/DetectionService.cs
Outdated
| string gameTitle = GetGameTitle(executablePath); | ||
|
|
||
| FileVersionInfo fileInformation = FileVersionInfo.GetVersionInfo(executablePath); | ||
| bool hasBadWordInDescription = fileInformation.FileDescription != null ? splashList.Where(bannedWord => fileInformation.FileDescription.ToLower().Contains(bannedWord)).Any() : false; |
There was a problem hiding this comment.
I tested this with an EAC game (Marauders) and found that the FileDescription is returning null, even though the file properties are filled out. I even checked to see ProductName and it also returns null. I think this might have something to do with EAC preventing us from looking at file properties?
Maybe if fileInformation.FileDescription == null, just return true? Would there be any cases where it would cause problems?
There was a problem hiding this comment.
Nevermind, it does cause problems. In my case, EAC also prevented me from checking the actual game executable's properties as well.
There was a problem hiding this comment.
To note, I'm not running with elevated privileges, and I didn't try it with them since I don't think RePlays should or need to run with elevated privileges to work. I also only tested this with one EAC game, so I can't say for others.
Are you able to see if you were able to test to see if FileDescription was null or empty? I noticed most fields were empty for the game I was testing, only useless details were not null, like the product/file version.
|
I will approve it anyways since this is a good implementation. We will have to look back at this in the future. |
This implementation works (surprising) well on all my installed games (Yes, I tested all).
The most significant improvement is the File Description check that checks if the description includes one of the banned words (launcher, splashscreen, cheat), see photo.