feat: Ability to name custom exes #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented a basic system for adding and naming custom detection exes. UI should probably be remade, I am not familiar with React
|
I like the idea! This works better than the current whitelist setting since it allows you to set the name of the application. I think this should replace the whitelist in the "Manage Games" section from the Advanced settings page and just merge it into the new Games settings page, and then rename Advanced to Storage. Here a quick mock up in paint to get my point across: I'll try to find some time this upcoming weekend (or sooner if I got the time) and try to implement it as such for you if you don't feel comfortable with React. |
|
I should be able to set that up without any real problems, you can always refine the UI later when you have time. |
Replaced blacklist/whitelist in Advanced with a separate Detection menu and renamed Advanced to Storage.
lulzsun
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a basic system for adding and naming custom detection exes through a separate menu.
Menu should probably be remade, I am not familiar with React.