-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Bookmark KeyboardHook (F8) #23
Conversation
I want to change the bookmark sound to the old Plays sound, but I have issues trying to retrieve it. |
I see you have created a We should either keep one or the other, or merge them together because they are essentially the same thing. |
Had no idea, how did I miss that 😁. |
//TODO: Add support for multiple keys (ex. Control + F8)
Code improvements
Done! @lulzsun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good, it could use some refactoring (merging the two key hook services into one) and coding style cleanup. But we can take care of that later.
I have not personally tested the functionality myself, but everything checks out so I'll give it the approval.
Thanks for the great work! 😁
You can now add bookmarks with the F8-key while in game.