Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Keybinding improvements #178

Merged
merged 1 commit into from
Feb 11, 2024
Merged

refactor: Keybinding improvements #178

merged 1 commit into from
Feb 11, 2024

Conversation

Segergren
Copy link
Contributor

@Segergren Segergren commented Feb 11, 2024 •
edited
Loading

  • Made it possible to press the keybinding while holding another key*
  • Improved speed from O(n log n) + O(m) to O(n)

* This is useful when you might already be holding down keys for other actions (e.g., sneaking with CTRL) and wish to trigger the bookmark (with F8) without needing to release the CTRL key.

lulzsun
lulzsun approved these changes Feb 11, 2024
View reviewed changes
Copy link
Owner

@lulzsun lulzsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ready to merge, thanks!

@lulzsun lulzsun merged commit b82f5e7 into lulzsun:main Feb 11, 2024
@Segergren Segergren deleted the keybinding-improvements branch February 27, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lulzsun lulzsun lulzsun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Segergren @lulzsun