Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support package presets #107

Closed
malaterre opened this issue Apr 17, 2023 · 7 comments
Closed

Support package presets #107

malaterre opened this issue Apr 17, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@malaterre
Copy link

In issue #102 workflow preset support was added, but not package preset. Could you please add "packagePreset" support just like configurePreset/buildPreset.

ref:

thanks !

malaterre added a commit to malaterre/vcpkg-dcmtk that referenced this issue Apr 17, 2023
@lukka lukka added the enhancement New feature or request label Apr 18, 2023
@lukka
Copy link
Owner

lukka commented Apr 19, 2023

@malaterre good idea! Would you be able to provide a small sample of how it would be used? I need to add a sample like the workflow one: https://github.com/lukka/CppBuildTasks-Validation/blob/v10/.github/workflows/hosted-cmake-workflow.yml
I haven't done my homework yet, and have these questions:

  • Is it mutually exclusive as the workflow preset?
  • Or it can go along with any of the configure/build/test presets?
  • Is the preset an argument to cpack or to cmake?

@malaterre
Copy link
Author

Hi lukka !

Here is what I did:

      - name: Manual CPack preset step
        run: cpack --preset '${{ env.CMAKE_PRESET }}'

This is definitely an option of cpack. I have not read on worflow stuff yet, so I do not know.

HTH

@lukka
Copy link
Owner

lukka commented Apr 21, 2023

@malaterre ok, go it. Would you mind testing this version suits your needs?
lukka/run-cmake@dev/package-preset

@malaterre
Copy link
Author

@lukka seems like I am missing something here:

@lukka
Copy link
Owner

lukka commented Apr 21, 2023

@malaterre thanks for trying, I fixed it, you may try again.

@malaterre
Copy link
Author

That worked out just fine:

Thanks !

@lukka lukka closed this as completed Apr 22, 2023
@lukka
Copy link
Owner

lukka commented Apr 22, 2023

Solved in #109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants