Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Show short url in invite dialog #995

Merged
merged 1 commit into from
Jan 25, 2024
Merged

🐛 Show short url in invite dialog #995

merged 1 commit into from
Jan 25, 2024

Conversation

lukevella
Copy link
Owner

@lukevella lukevella commented Jan 25, 2024

Summary by CodeRabbit

  • Refactor
    • The invite link display has been updated to exclude the protocol for cleaner presentation.

Copy link

vercel bot commented Jan 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2024 7:30am
landing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2024 7:30am

Copy link
Contributor

coderabbitai bot commented Jan 25, 2024

Walkthrough

The update to the CopyInviteLinkButton component involves displaying the invite link without including the protocol part. This is accomplished by utilizing a regular expression to strip off the protocol from the poll.inviteLink and storing the modified URL in a new variable, inviteLinkWithoutProtocol.

Changes

File Path Change Summary
.../web/src/components/... Updated CopyInviteLinkButton to display link without protocol

Poem

In the code where links are spun,
A rabbit tweaked the string for fun.
🎩✨No 'http://' to lead the way,
Just pure paths where invites stay.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 0384b5a and a0c6687.
Files selected for processing (1)
  • apps/web/src/components/invite-dialog.tsx (2 hunks)
Additional comments: 2
apps/web/src/components/invite-dialog.tsx (2)
  • 23-23: The regular expression used to remove the protocol from poll.inviteLink is correct and will effectively strip out 'http://' or 'https://'. However, consider edge cases where the URL might not have a protocol or has a different protocol (like 'ftp://').
  • 45-45: The usage of inviteLinkWithoutProtocol within the button label is correct and aligns with the PR's objective to display a shortened URL.

apps/web/src/components/invite-dialog.tsx Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant