Add tests #5
Add tests #5
Conversation
package.json
Outdated
| "license": "MIT" | ||
| "license": "MIT", | ||
| "dependencies": { | ||
| "tead": "^0.4.3" |
package.json
Outdated
| @@ -4,7 +4,13 @@ | |||
| "description": "Transforms arrays into virtual dom trees", | |||
| "main": "index.js", | |||
| "module": "index.js", | |||
| "scripts": { | |||
| "test": "tead" | |||
There was a problem hiding this comment.
Why not adding code coverage as well :tead --coverage ?
There was a problem hiding this comment.
Wait.. that wasn't as simple as it sounded 😅
$ tead --coverage
/bin/sh: npx: command not found
Done in 0.22s.
There was a problem hiding this comment.
Are you using Node.js < 8?
See the note here: https://github.com/teadjs/tead#npx
There was a problem hiding this comment.
I'm on v8.1.3 but I am not using npx anywhere in the project, or at all in fact
There was a problem hiding this comment.
Sorry, forgot thatnpx wasn't introduced in Node.js 8.0.0, but comes bundled with npm >= 5.2.0, which comes bundled with Node.js >= 8.2.0. 😂
It's not like I've already posted about this and forgot or anything 🙄
npx is a pretty cool tool that allows you to run a command from any package on npm without having to add it as a dependency, but the user still has control over which version they run. First it checks if the package is installed in node_modules, then globally, and finally it just downloads a copy of the latest version on-demand from npm as a last resort. 😎
c1b5f68 to
0344681
Compare
0344681 to
1f8728d
Compare
|
@lukejacksonn depending on how much more development/refactoring you're going to do on the project, you might also want a script that calls |
|
@okwolf ahh yeh.. thanks! |
Handles no children return with empty array instead of empty string, adds tests with tead. Any tips or ideas for tests?