Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diff: fix empty string handling #59

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

matej21
Copy link
Contributor

@matej21 matej21 commented Nov 2, 2020

Currently comparing with an empty strings throws following error:

TypeError: Cannot read property 'count' of undefined
    at chars (/..../node_modules/uvu/diff/index.js:95:36)

@codecov-io
Copy link

Codecov Report

Merging #59 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   90.16%   90.16%           
=======================================
  Files           3        3           
  Lines         305      305           
=======================================
  Hits          275      275           
  Misses         30       30           
Impacted Files Coverage Δ
src/diff.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2f2504...44f6c04. Read the comment docs.

Copy link
Owner

@lukeed lukeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thank you!

@lukeed lukeed merged commit a1a5621 into lukeed:master Nov 2, 2020
@lukeed
Copy link
Owner

lukeed commented Nov 2, 2020

Released in 0.3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants