fix(diff): retain undefined
and NaN
in output
#42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default,
JSON.stringify
hidesundefined
andNaN
values.This can be super annoying when your assertion fails correctly, but doesn't show you the reason(s) why. Take these comparisons for example:
You can see that direct, simple comparisons (via
assert.is
) are fine. But any instances within complex values (object, arrays) were lost. AKA, the{ foo: NaN }
was printed as{ foo: null }
-- hence grey text. We see this again with the last assertion with{ foo: null }
... and then{ foo: undefined }
is hidden entirely, leaving an emptyExpected:
block.After these changes,
undefined
andNaN
are printed in the diff'ing output so that we have true data representations~!