Merge pull request #4313 from luke-h1/fix/hotfix-tags

fix(frontend): hotfix tags
luke-h1 · Jan 14, 2024 · 4e497ce · 4e497ce
2 parents d79bbf5 + 80ef553
commit 4e497ce
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 11 deletions.
diff --git a/src/app/blog/[slug]/page.tsx b/src/app/blog/[slug]/page.tsx
@@ -63,13 +63,14 @@ const PostPage = async ({ params }: Props) => {
                 </Text>
               ),
             },
+            // todo: clean up the below - hotfix for potentially undefined tags
             {
-              ...(post.tags && {
-                title: 'Tags',
-                description: (
+              title: post.tags && post.tags.length > 0 ? 'Tags' : undefined,
+              description:
+                post.tags && post.tags.length > 0 ? (
                   // eslint-disable-next-line react/jsx-no-useless-fragment
                   <>
-                    {post.tags.length > 0
+                    {post.tags && post.tags.length > 0
                       ? post.tags.slice(0, 3).map(tag => (
                           <Link
                             href={`/blog/tags/${tag.slug.current}`}
@@ -90,8 +91,7 @@ const PostPage = async ({ params }: Props) => {
                         ))
                       : null}
                   </>
-                ),
-              }),
+                ) : undefined,
             },
           ]}
         />

diff --git a/src/components/Meta/Meta.tsx b/src/components/Meta/Meta.tsx
@@ -2,11 +2,13 @@ import { ReactNode, CSSProperties } from 'react';
 import SocialShare from '../SocialShare/SocialShare';
 import * as styles from './Meta.css';
 
+export interface MetaItem {
+  title: ReactNode;
+  description: ReactNode;
+}
+
 interface Props {
-  items: {
-    title: ReactNode;
-    description: ReactNode;
-  }[];
+  items?: MetaItem[];
 }
 
 const Meta = ({ items }: Props) => {
@@ -15,7 +17,7 @@ const Meta = ({ items }: Props) => {
       className={styles.root}
       style={
         {
-          '--length': items.length,
+          '--length': items?.length,
         } as CSSProperties
       }
     >