Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ImportError with pydantic 2.0 #35

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Fix ImportError with pydantic 2.0 #35

merged 1 commit into from
Jul 14, 2023

Conversation

szabi
Copy link
Contributor

@szabi szabi commented Jul 14, 2023

What kind of change does this PR introduce?

  • Bugfix
  • New Feature
  • Feature Improvement
  • Refactoring
  • Documentation
  • Other, please describe:

Description:

Makes streamlit-pydantic compatible with pydantic~=2.0.

Checklist:

  • I have read the CONTRIBUTING document.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@szabi szabi requested a review from lukasmasuch as a code owner July 14, 2023 10:51
@szabi
Copy link
Contributor Author

szabi commented Jul 14, 2023

Fixes #33

@lukasmasuch lukasmasuch merged commit 1c72c4a into lukasmasuch:main Jul 14, 2023
@szabi
Copy link
Contributor Author

szabi commented Jul 14, 2023

Github actions do not seem to run, but that seems to be an unrealted having persisted previously.

Will you make a pypi distribution?
Thx

@szabi
Copy link
Contributor Author

szabi commented Jul 14, 2023

Also, the deployed streamlit.app should be updated to work again: https://lukasmasuch-streamlit-pydantic-playgroundplayground-app-711bhu.streamlit.app/

@szabi szabi mentioned this pull request Jul 14, 2023
Open
@frederickmannings frederickmannings mentioned this pull request Jul 23, 2023
Open
@jamesbraza jamesbraza mentioned this pull request Oct 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasmasuch lukasmasuch Awaiting requested review from lukasmasuch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szabi @lukasmasuch