Fix missing support for cc and bcc recipients #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ients when applicable, falling back to envelope recipients if not
…es, rather than objects defining email, name and type of recipient
Closed
|
Sorry, I’ll take a look at this today or tomorrow |
luisdalmolin
approved these changes
Sep 2, 2022
|
Thanks, merged and tagged https://github.com/luisdalmolin/laravel-mandrill-driver/releases/tag/4.0.2. Thanks for the PR, sorry for the delay, for some reason didn't get any notifications about it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves issue #29 and adds support for the cc and bcc recipients that were previously present prior to v4.0.0. It checks the type of the original message and, in case of it being of the type
Symfony\Component\Mime\Email, it will use the existing methods in that class to retrieve theto,ccandbccrecipients.Note that the behaviour of this added functionality is similar to v3.x.x, meaning that all the recipients are considered as
torecipients on the Mandrill side. Each recipient will receive an individual mail message, rather than sending a group message with theto,ccandbccfields populated.Because I couldn't get the package running due to issue #32, I have forked this from PR #33. It means that this PR also contains the fix for issue #32 provided by @radykal-com.