Skip to content

Commit

Permalink
removed private github options from dockerfiles
Browse files Browse the repository at this point in the history
  • Loading branch information
luisguillenc committed Aug 27, 2020
1 parent 3530c7c commit f1f9203
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 24 deletions.
10 changes: 0 additions & 10 deletions Dockerfile.xlget
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,6 @@ FROM golang:1.14-alpine as build-env

# Arguments for build
ARG arch=amd64
# Set github user and token for private repositories
ARG github_user
ENV github_user=$github_user
ARG github_token
ENV github_token=$github_token

# Install git and certificates
RUN apk update && apk add --no-cache git make ca-certificates && update-ca-certificates
Expand All @@ -22,11 +17,6 @@ RUN adduser -D -g 'luids' luxlist \

WORKDIR /app

## config git
RUN if [ ! -z "$github_user" ]; then git config --global \
url."https://${github_user}:${github_token}@github.com/".insteadOf \
"https://github.com/"; fi

## dependences
COPY go.mod .
COPY go.sum .
Expand Down
10 changes: 0 additions & 10 deletions Dockerfile.xlistd
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,6 @@ FROM golang:1.14-alpine as build-env

# Arguments for build
ARG arch=amd64
# Set github user and token for private repositories
ARG github_user
ENV github_user=$github_user
ARG github_token
ENV github_token=$github_token

# Install git and certificates
RUN apk update && apk add --no-cache git make ca-certificates && update-ca-certificates
Expand All @@ -16,11 +11,6 @@ RUN adduser -D -g 'luids' luxlist

WORKDIR /app

## config git
RUN if [ ! -z "$github_user" ]; then git config --global \
url."https://${github_user}:${github_token}@github.com/".insteadOf \
"https://github.com/"; fi

## dependences
COPY go.mod .
COPY go.sum .
Expand Down
6 changes: 2 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,8 @@ clean:

docker:
@echo "$(WHALE) $@"
docker build -t xlistd -f Dockerfile.xlistd \
--build-arg github_user=${github_user} --build-arg github_token=${github_token} .
docker build -t xlget -f Dockerfile.xlget \
--build-arg github_user=${github_user} --build-arg github_token=${github_token} .
docker build -t xlistd -f Dockerfile.xlistd .
docker build -t xlget -f Dockerfile.xlget .

## Targets for Makefile.release
.PHONY: release
Expand Down

0 comments on commit f1f9203

Please sign in to comment.