FIX: Failure in TabTransformer Combiner Unit test #3596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment out corner cases that cause failure in tabtransformer combiner unit test.
remove single feature test cases because layernorm does not apply.
|
Based on discussion here pytorch/pytorch#108956, removing all test cases that generate single column batch for the parameter update check test for TabTransformerCombiner. |
justinxzhao
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Pull Requests
This is a temporary work-around for Issue #3591.
Comment out corner cases that cause failure in tabtransformer combiner unit test.
Root cause appears to be a recent change in PyTorch
LayerNormimplementation. See cited issue for details.