Don't generate SemanticDB for generated or external sources #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan28561
reviewed
Jan 27, 2025
| if ( | ||
| source.extension == "scala" and \ | ||
| source.is_source and \ | ||
| source.owner.workspace_name == ctx.label.workspace_name |
There was a problem hiding this comment.
since I'm seeing the word workspace here, is this bazel 8 compatible?
There was a problem hiding this comment.
Actually, it's not. Good catch. It seems it was deprecated in favor of the more accurately named repo_name:
https://bazel.build/rules/lib/builtins/Label#workspace_name
I'll correct this.
ryan28561
approved these changes
Jan 27, 2025
b3630c0 to
3723c3a
Compare
|
Squashed. |
09830b0 to
5f84626
Compare
|
Squashed. |
Previously, we only checked if a source ended with the "scala" extension before adding it to `SemanticDbInfo`. However, we don't want to generate SemanticDB files for generated files or external files, because they'll have the output directory (beginning with `bazel-out`) in their paths, which isn't guaranteed to be consistent. Also, tell the SemanticDB compiler plugin to generate SemanticDB outside of the output JAR, even if we don't want SemanticDB generated for any of the sources. That way, the output JAR won't include SemanticDB files we don't want.
6f3b476 to
1a8dcb0
Compare
|
Squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we only checked if a source ended with the "scala" extension before adding it to
SemanticDbInfo. However, we don't want to generate SemanticDB files for generated files or external files, because they'll have the output directory (beginning withbazel-out) in their paths, which isn't guaranteed to be consistent.Also, tell the SemanticDB compiler plugin to generate SemanticDB outside of the output JAR, even if we don't want SemanticDB generated for any of the sources. That way, the output JAR won't include SemanticDB files we don't want.